Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly verify Sec-WebSocket-Key header. #962

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Properly verify Sec-WebSocket-Key header. #962

merged 1 commit into from
Oct 25, 2023

Conversation

pydima
Copy link
Contributor

@pydima pydima commented Oct 24, 2023

Development guide

Link

Test on local before making the PR

go run ./lib/utils/simple-check

ysmood
ysmood requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@ysmood ysmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Please run go run ./lib/utils/simple-check on your local, you should be able to reproduce the CI error.

@ysmood
Copy link
Member

ysmood commented Oct 25, 2023

There's still a coverage issue, you need to update the test.

@ysmood ysmood enabled auto-merge (rebase) October 25, 2023 16:40
@ysmood ysmood merged commit 166b235 into go-rod:main Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysmood ysmood ysmood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pydima @ysmood